linux-kernel - Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Sep 2010 12:09:16 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
CC:	"rdunlap@...otime.net" <rdunlap@...otime.net>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped

On 09/01/2010 03:11 PM, Peter P Waskiewicz Jr wrote:
> On Wed, 2010-09-01 at 15:04 -0700, rdunlap@...otime.net wrote:
>> On Wed, September 1, 2010 2:33 pm, Peter P Waskiewicz Jr wrote:
>>> Documentation/x86/x86_64/boot-options.txt |    4 ++++
>>> arch/x86/mm/srat_64.c                     |   20 +++++++++++++++++--- 2
>>> files changed, 21 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c index
>>> f9897f7..8719472 100644 --- a/arch/x86/mm/srat_64.c
>>> +++ b/arch/x86/mm/srat_64.c
>>> @@ -351,6 +351,15 @@ int __init acpi_get_nodes(struct bootnode *physnodes)
>>>  return ret; }
>>>
>>>
>>> +int srat_bypass_bios = 0;
>>
>> static int srat_bypass_bios;
>>
>> Don't need to init to 0.
> 
> I'll fix and send a second version.  Thanks Randy.
> 

Should be static *bool* srat_bypass_bios;

Please use bool for actual booleans; it prevents someone from being
"smart" and using values like 2 or -1 for "special cases".

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/