linux-kernel - Re: [patch 27/30] staging: Bulk convert the semaphore mess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100908023019.GA25440@kroah.com>
Date:	Tue, 7 Sep 2010 19:30:19 -0700
From:	Greg KH <greg@...ah.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Christoph Hellwig <hch@...radead.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [patch 27/30] staging: Bulk convert the semaphore mess

On Tue, Sep 07, 2010 at 02:33:47PM -0000, Thomas Gleixner wrote:
> init_MUTEX(_LOCKED) and DECLARE_MUTEX are going away. Bulk convert
> staging users.

I don't think you actually built this change:

> --- linux-2.6.orig/drivers/staging/comedi/drivers/usbdux.c
> +++ linux-2.6/drivers/staging/comedi/drivers/usbdux.c
> @@ -315,7 +315,7 @@ struct usbduxsub {
>   */
>  static struct usbduxsub usbduxsub[NUMUSBDUX];
>  
> -static DECLARE_MUTEX(start_stop_sem);
> +static DEFINE_SEMAPHORE(start_stop_sem);
>  
>  /*
>   * Stops the data acquision

I don't see DEFINE_SEMAPHORE() in Linus's tree, what should we use
instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/