linux-kernel - Re: [RFC 06/22] tcm: Add ConfigFS subsystem backstore infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201009072241.25115.konrad@darnok.org>
Date:	Tue, 7 Sep 2010 22:41:23 -0400
From:	Konrad Rzeszutek Wilk <konrad@...nok.org>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Joel Becker <Joel.Becker@...cle.com>
Cc:	"linux-scsi" <linux-scsi@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Mike Christie <michaelc@...wisc.edu>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	James Bottomley <James.Bottomley@...e.de>,
	Jens Axboe <axboe@...nel.dk>,
	Boaz Harrosh <bharrosh@...asas.com>
Subject: Re: [RFC 06/22] tcm: Add ConfigFS subsystem backstore infrastructure

On Monday 30 August 2010 05:20:58 Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@...ux-iscsi.org>
>
> This patch adds the TCM/ConfigFS core HBA and device backstore
> infrastructre objects in /sys/kernel/config/target/core.  It includes
> wrappers to logic for Persistent Reservations and ALUA, and supports
> Linux/SCSI, Linux/BLOCK, and Linux/FILEIO backstores using TCM subsystem
> plugin API.
>
> Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org>
> ---
>  drivers/target/target_core_configfs.c | 3334

Considering this is in configfs, you should copy  Joel on this. I added him on 
the huge CC-list.

The only comments I've about this file is the majority of the printk should be 
KERN_DEBUG and that the EXPORT_SYMBOL should be EXPORT_SYMBOL_GPL.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/