linux-kernel - Re: [PATCH] west bridge, block driver fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100907235453.GA12823@kroah.com>
Date:	Tue, 7 Sep 2010 16:54:53 -0700
From:	Greg KH <greg@...ah.com>
To:	David Cross <david.cross@...ress.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] west bridge, block driver fixes

On Tue, Sep 07, 2010 at 12:37:33PM -0700, David Cross wrote:
> This patch makes minor fixes to the block driver for locking issues,
> printk statements and minor change for a kernel update to 2.6.36.
> Please let me know if there are issues or concerns with this patch.

Again, you are doing at least 3 different things here, right?  Please
split them out into 3 different patches.

Remember, one patch per logical change please.

> Signed-off-by: David Cross <david.cross@...ress.com>
> 
> diff -uprN -X linux-next-vanilla/Documentation/dontdiff linux-next-vanilla/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c linux-next-incl-sdk/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c
> --- linux-next-vanilla/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c	2010-08-31 19:32:51.000000000 -0700
> +++ linux-next-incl-sdk/drivers/staging/westbridge/astoria/block/cyasblkdev_block.c	2010-09-07 11:28:49.000000000 -0700
> @@ -202,7 +202,7 @@ static struct cyasblkdev_blk_data *cyasb
>  	if (bd) {
>  		bd->usage++;
>  		#ifndef NBDEBUG
> -		cy_as_hal_print_message(
> +		printk(KERN_INFO
>  			"cyasblkdev_blk_get: usage = %d\n", bd->usage) ;
>  		#endif

No, just use dev_dbg() here then you can drop the #ifdef.

Oh wait, it's the other way around?  If you don't have debugging enabled
you want to print that message?  Huh?  Just drop the #ifndef and then
use dev_info() instead.  That will properly print out the device and
driver that is being used here.

You can do that for all of your *hal_print_message() calls.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/