linux-kernel - Re: [PATCH] spi/spi_s3c64xx: Move to subsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Sep 2010 13:55:39 +0900
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Jassi Brar <jassi.brar@...sung.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	spi-devel-general@...ts.sourceforge.net,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi/spi_s3c64xx: Move to subsys_initcall()

On Tue, Sep 7, 2010 at 7:29 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> Allow the use of the S3C64xx SPI controller with things like PMICs by
> moving the init up to subsys_initcall().
>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>
> Incidentally I don't seem to see anything in the current SPI tree for
> -next - should the tree being used be updated or something?
>
>  drivers/spi/spi_s3c64xx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
> index f72e1c0..6e48ea9 100644
> --- a/drivers/spi/spi_s3c64xx.c
> +++ b/drivers/spi/spi_s3c64xx.c
> @@ -1181,7 +1181,7 @@ static int __init s3c64xx_spi_init(void)
>  {
>        return platform_driver_probe(&s3c64xx_spi_driver, s3c64xx_spi_probe);
>  }
> -module_init(s3c64xx_spi_init);
> +subsys_initcall(s3c64xx_spi_init);

Couldn't any user ever need to load it as a module?
If no, we might as well drop the s3c64xx_spi_exit and s3c64xx_spi_remove
as well and save space. Rather going a step further, shouldn't then all
spi drivers be that way? Two steps further, why not every 'bus-driver' ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/