linux-kernel - Re: [PATCH] west bridge, kconfig and hal fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100907235704.GC12823@kroah.com>
Date:	Tue, 7 Sep 2010 16:57:04 -0700
From:	Greg KH <greg@...ah.com>
To:	David Cross <david.cross@...ress.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] west bridge, kconfig and hal fixes

On Tue, Sep 07, 2010 at 12:22:10PM -0700, David Cross wrote:

First off, what's with the "Re:" of the Subject?  What are you
responding to here?

> This patch contains the kconfig changes necessary to fix build errors
> that could come up in the linux-next version. It also includes an
> additional HAL layer for the west bridge CRAM interface.

Again, one patch per change, please break this up.

> The inclusion
> of this interface support did require the reorganization of some of the
> existing code, which is part of the reason for the size of the patch.
> Moving files and directories makes this patch seem larger than it really
> is.

If you use git you can send a patch that properly shows only what
changes even if the file is moved.  Care to do that?

> The Kconfig changes are closely related to the inclusion of the CRAM
> HAL layer, and as such this patch is difficult to logically separate. 

Why is it necessary?

> The linux-next tree does not seem to have a config for the zoom2, and
> trying to build it for that board seems to make the compilation break.

Why should the driver care about which arch it is built for?  It should
build on _all_ arches, right?

> As such, the only thing that I tested was compilation using the two
> different HALs (one of which is added in this patch). Please let me know
> if there are problems or questions with this.

Why do you need a "HAL" at all here?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/