linux-kernel - Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Sep 2010 09:49:08 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	venki kaps <venkiece2005@...il.com>
Cc:	greg@...ah.com, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Felipe Balbi <me@...ipebalbi.com>,
	Anand Gadiyar <gadiyar@...com>
Subject: Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

2010/9/8 venki kaps <venkiece2005@...il.com>:

>  To resolve the above issue, we have made "PHY power on" in battery
> adc on function
>  and "PHY power down" in battery adc off function.

Good news, the temperature is bad value from battery adc if otg phy is power
down. Maybe you only need to power on otg phy before reading battery adc, then
power down otg phy after the reading if no usb calbe is connected with musb
for decreasing power consumption. (I am not familiar with battery adc, just
for your refrerence)

Anyway, your issue(reading mistaken temperature) is nothing to do with
twl_4030 otg driver and the patch, we does need to power down otg phy
if no vbus or ID event detected.

-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/