linux-kernel - Re: scsi_cmnd data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Sep 2010 12:34:55 -0700 (PDT)
From:	Anil kumar <anils_r@...oo.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
Cc:	Christof Schmitt <christof.schmitt@...ibm.com>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: scsi_cmnd data_buffer checksum

Martin,

Thanks. I will go thru the DIF document and code. 

But I had a quick question, isn't that drive has to support "protection enable" also. Also, does Controller FW need to do anything extra to send DIF block down to drive. Ideally we will be sending 512 byte blocks down to drive.

-Anil

--- On Thu, 9/9/10, Martin K. Petersen <martin.petersen@...cle.com> wrote:

> From: Martin K. Petersen <martin.petersen@...cle.com>
> Subject: Re: scsi_cmnd data_buffer checksum
> To: "Anil kumar" <anils_r@...oo.com>
> Cc: "Christof Schmitt" <christof.schmitt@...ibm.com>, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
> Date: Thursday, September 9, 2010, 9:23 AM
> >>>>> "Anil" == Anil
> kumar <anils_r@...oo.com>
> writes:
> 
> Anil> cmd-> write_buf = (u8
> *)(kmap_atomic(sg->page, KM_IRQ0) + sg->offset);
> Anil> memcpy(cmd->local_write_buf, cmd->write_buf,
> cmd->scsibufflen(scsi_cmnd));
> 
> You need to walk the scatterlist.  You can't assume
> that the pages are
> contiguous in memory.
> 
> But why are you doing this checksumming stuff manually when
> the existing
> DIX/DIF code can do it for you?
> 
> -- 
> Martin K. Petersen    Oracle Linux
> Engineering
> 


      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/