linux-kernel - Re: [PATCH 09/24] msm: MSM8X60 RUMI3 board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Sep 2010 20:15:00 -0700
From:	Jeff Ohlstein <johlstei@...eaurora.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	Daniel Walker <dwalker@...eaurora.org>,
	linux-arm-msm@...r.kernel.org,
	Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
	Gregory Bean <gbean@...eaurora.org>,
	linux-kernel@...r.kernel.org,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Steve Muckle <smuckle@...eaurora.org>,
	Stepan Moskovchenko <stepanm@...eaurora.org>,
	Brian Swetland <swetland@...gle.com>,
	David Brown <davidb@...eaurora.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 09/24] msm: MSM8X60 RUMI3 board support

Russell King - ARM Linux wrote:
> On Tue, Aug 24, 2010 at 09:57:38PM -0700, Jeff Ohlstein wrote:
>   
>> +
>> +extern struct sys_timer msm_timer;
>> +void __iomem *gic_cpu_base_addr;
>>     
> Please move to a header file.
>   
I can move the extern to a header, not sure about the gic_cpu_base_addr. 
Seems like other machine types have it in C code. Even with a prototype 
in a header I need to define it somewhere.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/