linux-kernel - Re: [PATCHv6 3/3] mmc_test: collect data and show it via sysfs by demand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Sep 2010 20:59:51 -0700
From:	Greg KH <greg@...ah.com>
To:	Chris Ball <cjb@...top.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hunter Adrian <adrian.hunter@...ia.com>,
	Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
Subject: Re: [PATCHv6 3/3] mmc_test: collect data and show it via sysfs by
	demand

On Tue, Sep 07, 2010 at 11:58:43PM +0100, Chris Ball wrote:
> On Tue, Sep 07, 2010 at 03:27:53PM -0700, Andrew Morton wrote:
> > So what we end up with is extremely thin.  Something about adding
> > something to sysfs.
> > 
> > This is not enough!  You're proposing an addition to the kernel->user
> > ABI.  Please fully describe this interface so that we can understand
> > and review it.  What are the names of these sysfs files?  What do they
> > do?  Provide us with example output in the changelog so we can see for
> > ourselves.
> 
> Hoping Andy doesn't mind me jumping in, here's an attempt at a better
> changelog:
> 
> ---
> 
> Prior to this patch, the "test" file under each card's sysfs node was
> write-only, and results were obtained by looking at dmesg.  This patch
> improves programmatic access to the test results, making them available
> by reading back from the same "test" file:
> 
> [root@...t mmc0:e624]# echo 6 > test
> [root@...t mmc0:e624]# cat test
> Test 6: 2

Ick, no.

Why is this in sysfs at all anyway?

Why not put it in debugfs?

And for every sysfs file, you need to have a Documenation/ABI/ entry.

Remember, sysfs is "one value per file".  Does that work with this file?
At first glance, it doesn't look like it.

Please use debugfs instead.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/