linux-kernel - Re: [PATCH] get_maintainer.pl: append reason for cc to the name by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1284115665.1783.144.camel@Joe-Laptop>
Date:	Fri, 10 Sep 2010 03:47:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	florian@...kler.org, Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Hemminger <shemminger@...tta.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] get_maintainer.pl: append reason for cc to the name by
 default

On Fri, 2010-09-10 at 11:18 +0100, Mark Brown wrote:
> On Fri, Sep 10, 2010 at 03:04:26AM -0700, Joe Perches wrote:
> > One possible improvement that get_maintainers could
> > add is to [optionally] CC the author of the first
> > commit when there's no listed maintainer.
> 
> That might be a nice option (though it will still give false positives).

Anything that uses git will give false positives.
Anything that uses MAINTAINERS will give false positives.

> Something based on percentage of the driver written rather than log
> entry counts might also be interesting.

There is a --git-blame option, but it uses a count of file commits
active in the file rather than % of lines authored.

For instance:

$ ./scripts/get_maintainer.pl --git-blame --rolestats -f arch/arm/mach-kirkwood/common.c
Lennert Buytenhek <kernel@...tstofly.org> (odd fixer:ARM/Marvell Loki/...,commits:11/38=29%)
Nicolas Pitre <nico@...xnic.net> (odd fixer:ARM/Marvell Loki/...,commit_signer:7/12=58%,commits:22/38=58%)
Russell King <linux@....linux.org.uk> (maintainer:ARM PORT,commits:3/38=8%)
Mark Brown <broonie@...nsource.wolfsonmicro.com> (commit_signer:3/12=25%)
Liam Girdwood <lrg@...mlogic.co.uk> (commit_signer:3/12=25%)
Saeed Bishara <saeed@...vell.com> (commit_signer:3/12=25%,commits:6/38=16%)
Arnaud Patard <arnaud.patard@...-net.org> (commit_signer:2/12=17%)
Ronen Shitrit <rshitrit@...vell.com> (commits:5/38=13%)
linux-arm-kernel@...ts.infradead.org (open list:ARM/Marvell Loki/...)
linux-kernel@...r.kernel.org (open list)

Maybe --rolestats should be extended to include line counts
if --git-blame is used.

--git-blame can be very slow, it shouldn't be a default option.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/