linux-kernel - Re: [PATCH] AT91: at91sam9261ek board: remove warnings related to use of SPI or SD/MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Sep 2010 13:25:31 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Sergei Shtylyov <sshtylyov@...sta.com>, avictor.za@...il.com
CC:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] AT91: at91sam9261ek board: remove warnings related to
 use of SPI or SD/MMC

Le 10/09/2010 13:06, Jean-Christophe PLAGNIOL-VILLARD :
>>>   * ADS7846 Touchscreen
>>> @@ -357,6 +350,21 @@ static struct spi_board_info ek_spi_devices[] = {
>>>  #endif
>>>  };
>>>
>>> +#else /* CONFIG_SPI_ATMEL_* */
>>> +
>>> +/*
>>> + * MCI (SD/MMC)
>>> + * spi0 and mmc/sd share the same PIO pins: cannot be used at the same time
>>> + */
>>> +static struct at91_mmc_data __initdata ek_mmc_data = {
>>> +	.wire4		= 1,
>>> +//	.det_pin	= ... not connected
>>> +//	.wp_pin		= ... not connected
>>> +//	.vcc_pin	= ... not connected
>>
>>    The coding style document forbids C99 style // comments. Could
>> replace with normal comment or #if 0...
> no dead code please

I kept those comments because it is just a move of code.

But ok, it seem that they are not liked by several people. As I am in a
"tiny fixes" mood, I post an additional patch to remove them ;-)

Cheers,
-- 
Nicolas Ferre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/