linux-kernel - Re: [PATCH] perf_events: fix BTS interrupt handling to avoid being dazed by NMI (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100910132528.GA4879@redhat.com>
Date:	Fri, 10 Sep 2010 09:25:28 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	paulus@...ba.org, davem@...emloft.net, fweisbec@...il.com,
	perfmon2-devel@...ts.sf.net, eranian@...il.com,
	robert.richter@....com
Subject: Re: [PATCH] perf_events: fix BTS interrupt handling to avoid being
 dazed by NMI (v2)

On Fri, Sep 10, 2010 at 01:28:01PM +0200, Stephane Eranian wrote:
> Fix a bug introduced with commit de725de and the change in the meaning of the
> return value of intel_pmu_handle_irq(). With the current code, when you are
> using the BTS, you get 'dazed by NMI' each time the BTS buffer fills up.
> 
> BTS does interrupt on the PMU vector, thus NMI. You need to take this
> into account in the return value of the function.
> 
> This version fixes initial patch which was missing changes to
> perf_event_intel_ds.c.

Great work!

So does this mean my other patch that ack'd the intel pmu earlier than
before is unnecessary now?  Or was this patch solving a different problem?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/