linux-kernel - [PATCH] drivers/net/usb/hso.c: prevent reading uninitialized memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=RrFrYkWVHhLmyA21zNdb3KdaGXRCgLxVgZkah@mail.gmail.com>
Date:	Sat, 11 Sep 2010 19:46:35 -0400
From:	Dan Rosenberg <dan.j.rosenberg@...il.com>
To:	j.dumon@...ion.com
Cc:	linux-kernel@...r.kernel.org, security@...nel.org
Subject: [PATCH] drivers/net/usb/hso.c: prevent reading uninitialized memory

The TIOCGICOUNT device ioctl allows unprivileged users to read 9 bytes
of uninitialized stack memory, because the "reserved" member of the
serial_icounter_struct struct declared on the stack in hso_get_count()
is not altered or zeroed before being copied back to the user.  This
patch takes care of it.

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@...il.com>

--- linux-2.6.35.4.orig/drivers/net/usb/hso.c	2010-09-11
19:12:00.000000000 -0400
+++ linux-2.6.35.4/drivers/net/usb/hso.c	2010-09-11 19:15:23.000000000 -0400
@@ -1653,6 +1653,8 @@ static int hso_get_count(struct hso_seri
 	struct uart_icount cnow;
 	struct hso_tiocmget  *tiocmget = serial->tiocmget;

+	memset(&icount, 0, sizeof(struct serial_icounter_struct));
+
 	if (!tiocmget)
 		 return -ENOENT;
 	spin_lock_irq(&serial->serial_lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/