linux-kernel - [PATCH] drivers/net/cxgb3/cxgb3_main.c: prevent reading uninitialized stack memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AANLkTimR48NwOCgB81RhNbCz=YzZmcCcyb0qsYg_dHuq@mail.gmail.com>
Date:	Sat, 11 Sep 2010 19:46:43 -0400
From:	Dan Rosenberg <dan.j.rosenberg@...il.com>
To:	divy@...lsio.com
Cc:	linux-kernel@...r.kernel.org, security@...nel.org
Subject: [PATCH] drivers/net/cxgb3/cxgb3_main.c: prevent reading uninitialized
 stack memory

The CHELSIO_GET_QSET_NUM device ioctl allows unprivileged users to
read 4 bytes of uninitialized stack memory, because the "addr" member
of the ch_reg struct declared on the stack in cxgb_extension_ioctl()
is not altered or zeroed before being copied back to the user.  This
patch takes care of it.

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@...il.com>

--- linux-2.6.35.4.orig/drivers/net/cxgb3/cxgb3_main.c	2010-09-11
19:12:43.000000000 -0400
+++ linux-2.6.35.4/drivers/net/cxgb3/cxgb3_main.c	2010-09-11
19:18:42.000000000 -0400
@@ -2296,6 +2296,8 @@ static int cxgb_extension_ioctl(struct n
 	case CHELSIO_GET_QSET_NUM:{
 		struct ch_reg edata;

+		memset(&edata, 0, sizeof(struct ch_reg));
+
 		edata.cmd = CHELSIO_GET_QSET_NUM;
 		edata.val = pi->nqsets;
 		if (copy_to_user(useraddr, &edata, sizeof(edata)))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/