[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <201009121926.08633.rjw@sisk.pl>
Date: Sun, 12 Sep 2010 19:26:08 +0200
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: Randy Dunlap <randy.dunlap@...cle.com>
Cc: lkml <linux-kernel@...r.kernel.org>,
linux-pm@...ts.linux-foundation.org
Subject: Re: [PATCH] PM_SLEEP_SMP: fix kconfig warning
On Sunday, September 12, 2010, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
>
> Fix kconfig unmet dependency warning:
>
> warning: (PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE) && PM_SLEEP) selects HOTPLUG_CPU which has unmet direct dependencies (SMP && HOTPLUG)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
> kernel/power/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100908.orig/kernel/power/Kconfig
> +++ linux-next-20100908/kernel/power/Kconfig
> @@ -83,7 +83,7 @@ config PM_TRACE_RTC
>
> config PM_SLEEP_SMP
> bool
> - depends on SMP
> + depends on SMP && HOTPLUG
> depends on ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE
> depends on PM_SLEEP
> select HOTPLUG_CPU
I'm afraid that may cause some people to find that suspend is not compiled in
to their surprise.
Would it be possible to select both HOTPLUG and HOTPLUG_CPU instead (ie. would
that work)?
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists