linux-kernel - Re: [PATCH] nconfig: Fix help for choice menus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Sep 2010 11:06:16 +0300
From:	Nir Tzachar <nir.tzachar@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	bebarino@...il.com
Subject: Re: [PATCH] nconfig: Fix help for choice menus

On Fri, Sep 10, 2010 at 11:32 AM, Stephen Boyd <bebarino@...il.com> wrote:
> When getting the help for a choice menu with a help section (for example
> the "Choose SLAB allocator" menu) nconfig pops up a window with nothing
> inside it. This is due to show_help() passing an empty string to
> show_scroll_win()'s 3rd argument. The option really does have help
> though, but it isn't a config symbol, so just add the help text for
> the option, and don't try to add anything else like the config option
> name.


Acked-by: Nir Tzachar <nir.tzachar@...il.com>

> Signed-off-by: Stephen Boyd <bebarino@...il.com>
> Cc: Nir Tzachar <nir.tzachar@...il.com>
> ---
>  scripts/kconfig/nconf.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 2ba71bc..19d3401 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -1252,6 +1252,8 @@ static void show_help(struct menu *menu)
>                        str_append(&help, _(menu_get_help(menu)));
>                        str_append(&help, "\n");
>                        get_symbol_str(&help, menu->sym);
> +               } else {
> +                       str_append(&help, _(menu_get_help(menu)));
>                }
>        } else {
>                str_append(&help, nohelp_text);
> --
> 1.7.2.3.313.gcd15
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/