linux-kernel - Re: [PATCH] fs/btrfs/ordered-data.c: fixed compiler warnings for using uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimU2k6=GPgMsabqpv+uwTVWtSoOoUmwOBbSAT4K@mail.gmail.com>
Date:	Sun, 12 Sep 2010 13:36:21 +0300
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	Frank Morales II <altf2o@...il.com>
Cc:	chris.mason@...cle.com, josef@...hat.com, zheng.yan@...cle.com,
	jens.axboe@...cle.com, tj@...nel.org, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/btrfs/ordered-data.c: fixed compiler warnings for
 using uninitialized variable

On Fri, Sep 10, 2010 at 5:42 PM, Frank Morales II <altf2o@...il.com> wrote:
> >From 1c304defc543738f82ccb18fe10b558dd2098d74 Mon Sep 17 00:00:00 2001
> From: Frank Morales II <altf2o@...il.com>
> Date: Fri, 10 Sep 2010 07:34:23 -0700
> Subject: [PATCH] fs/btrfs/ordered-data.c: fixed compiler warnings for using uninitialized variable
>
> In the function tree_search, the variable prev was used without first
> being initialized, causing compiler warning messages. Initializing
> prev to NULL resolved the issue.
>
> Kernal patched against: 2.6.36-rc3 (df423dc7)

Signed-of-by: Felipe Contreras <felipe.contreras@...il.com>

I came up with exactly this patch, but this is my commit message:

    Btrfs: fix compilation warning

    fs/btrfs/ordered-data.c: In function ‘tree_search’:
    fs/btrfs/ordered-data.c:144: warning: ‘prev’ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c: In function ‘btrfs_lookup_first_ordered_extent’:
    fs/btrfs/ordered-data.c:144: warning: ‘prev’ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: ‘prev’ was declared here
    fs/btrfs/ordered-data.c: In function ‘btrfs_lookup_ordered_extent’:
    fs/btrfs/ordered-data.c:144: warning: ‘prev’ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: ‘prev’ was declared here
    fs/btrfs/ordered-data.c: In function ‘btrfs_lookup_ordered_range’:
    fs/btrfs/ordered-data.c:144: warning: ‘prev’ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: ‘prev’ was declared here
    fs/btrfs/ordered-data.c: In function ‘btrfs_dec_test_ordered_pending’:
    fs/btrfs/ordered-data.c:144: warning: ‘prev’ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: ‘prev’ was declared here

    __tree_search() might not set &prev.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/