linux-kernel - Re: [PATCH] drivers: s390: remove custom implementation of hex_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100913080427.GA2310@osiris.boeblingen.de.ibm.com>
Date:	Mon, 13 Sep 2010 10:04:27 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux390@...ibm.com, linux-s390@...r.kernel.org
Subject: Re: [PATCH] drivers: s390: remove custom implementation of
 hex_to_bin()

On Sat, Sep 11, 2010 at 04:36:38PM +0300, Andy Shevchenko wrote:
> diff --git a/drivers/s390/cio/blacklist.c b/drivers/s390/cio/blacklist.c
> index 13cb601..76058a5 100644
> --- a/drivers/s390/cio/blacklist.c
> +++ b/drivers/s390/cio/blacklist.c
> @@ -79,17 +79,15 @@ static int pure_hex(char **cp, unsigned int *val, int min_digit,
>  		    int max_digit, int max_val)
>  {
>  	int diff;
> -	unsigned int value;
> 
>  	diff = 0;
>  	*val = 0;
> 
> -	while (isxdigit(**cp) && (diff <= max_digit)) {
> +	while (diff <= max_digit) {
> +		int value = hex_to_bin(**cp);
> 
> -		if (isdigit(**cp))
> -			value = **cp - '0';
> -		else
> -			value = tolower(**cp) - 'a' + 10;
> +		if (value < 0)
> +			break;
>  		*val = *val * 16 + value;
>  		(*cp)++;
>  		diff++;

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/