linux-kernel - Re: [PATCH] x86: EuroBraille/Iris power off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54870.1284390647@localhost>
Date:	Mon, 13 Sep 2010 11:10:47 -0400
From:	Valdis.Kletnieks@...edu
To:	Shérab <Sebastien.Hinderer@...-lyon.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Len Brown <lenb@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andres Salomon <dilinger@...ued.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Samuel Thibault <Samuel.Thibault@...-lyon.org>
Subject: Re: [PATCH] x86: EuroBraille/Iris power off

On Mon, 13 Sep 2010 12:07:19 +0200, Shérab said:

> +static int iris_init(void)
> +{
> +	unsigned char status = inb(IRIS_GIO_INPUT);
> +	if (status == IRIS_GIO_NODEV) {
> +		printk(KERN_ERR "This machine does not seem to be an Iris. Power_off handler not installed.\n");
> +		return -ENODEV;
> +	}

Is it actually safe to assume that this will do the right thing on a machine that
is a non-Iris that has something *else* at that I/O  address?  Any further sanity
checking we can do?  (For that matter, are there machines that will get indigestion
at this sort of unexpected inb() access?)

Content of type "application/pgp-signature" skipped