linux-kernel - Re: amba_pl022 spi->mode fix/cleanup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimtR6+TFX8w1_6MEEqbvk5-StkUTn5kKd4q3DeZ@mail.gmail.com>
Date:	Mon, 13 Sep 2010 17:19:31 +0200
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	wellsk40@...il.com
Cc:	spi-devel-general@...ts.sourceforge.net,
	rabin.vincent@...ricsson.com, linux@....linux.org.uk,
	sameo@...ux.intel.com, srinidhi.kasagar@...ricsson.com,
	Lukasz.Baj@...to.com, linux-kernel@...r.kernel.org,
	u.kleine-koenig@...gutronix.de, tj@...nel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: amba_pl022 spi->mode fix/cleanup patches

2010/9/10  <wellsk40@...il.com>:

> This patch series updates drivers and platforms that depend on the
> amba_pl022 driver and use the pl022_config_chip structure for
> setting up the SPI mode and data transfer width.

I get regressions from the ab8500-spi.c driver from this patch:

> ssp-pl022 ssp0: ARM PL022 driver, device ID: 0x01080022
> pl022: mapped registers from 0x80002000 to d0834000
> ab8500-spi spi0.0: unknown chip, revision: 0x80
> ab8500-spi: probe of spi0.0 failed with error -22

The 0x80 above used to be 0x00 before these patches.
So all of a sudden bit 7 gets set...

I don't know why this happens, probably some flag that used to
be set had not been properly propagated in the first patch to alter
the AB8500 device registration?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/