linux-kernel - Re: [PATCH] ACPI: sleep: init_set_sci_en_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Sep 2010 10:44:59 -0700
From:	Kamal Mostafa <kamal@...onical.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Len Brown <lenb@...nel.org>, Matthew Garrett <mjg@...hat.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH] ACPI: sleep: init_set_sci_en_on_resume for Dell Studio
 155x

On Mon, 2010-09-13 at 19:34 +0200, Rafael J. Wysocki wrote:
> On Thursday, April 29, 2010, Kamal Mostafa wrote:
> > Add Dell Studio models (1558, 1557, 1555) to the 'set_sci_en_on_resume'
> > list to fix hang on resume.
> > 
> > BugLink: http://bugs.launchpad.net/bugs/553498
> 
> This check was removed by commit b6dacf63e9fb2e7a1369843d6cef332f76fca6a3
> (ACPI: Unconditionally set SCI_EN on resume), so the patch shouldn't be
> necessary.

That is correct Rafael.  I confirm that this Dell-specific patch is no
longer relevant.  Thanks,

 -Kamal


> Thanks,
> Rafael
> 
> 
> > Signed-off-by: Kamal Mostafa <kamal@...onical.com>
> > Acked-by: Alex Chiang <achiang@...onical.com>
> > Cc: stable@...nel.org
> > ---
> >  drivers/acpi/sleep.c |   24 ++++++++++++++++++++++++
> >  1 files changed, 24 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> > index f74834a..d907c8a 100644
> > --- a/drivers/acpi/sleep.c
> > +++ b/drivers/acpi/sleep.c
> > @@ -458,6 +458,30 @@ static struct dmi_system_id __initdata acpisleep_dmi_table[] = {
> >  		DMI_MATCH(DMI_BOARD_NAME, "CF51-2L"),
> >  		},
> >  	},
> > +	{
> > +	.callback = init_set_sci_en_on_resume,
> > +	.ident = "Dell Studio 1558",
> > +	.matches = {
> > +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +		DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1558"),
> > +		},
> > +	},
> > +	{
> > +	.callback = init_set_sci_en_on_resume,
> > +	.ident = "Dell Studio 1557",
> > +	.matches = {
> > +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +		DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557"),
> > +		},
> > +	},
> > +	{
> > +	.callback = init_set_sci_en_on_resume,
> > +	.ident = "Dell Studio 1555",
> > +	.matches = {
> > +		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +		DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1555"),
> > +		},
> > +	},
> >  	{},
> >  };
> >  #endif /* CONFIG_SUSPEND */
> > 
> 


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)