linux-kernel - Re: [PATCH] ACPI: apei: Cast u64 to unsigned long, fix compile warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100913130035.decb0d44.akpm@linux-foundation.org>
Date:	Mon, 13 Sep 2010 13:00:35 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
Cc:	Len Brown <lenb@...nel.org>, Huang Ying <ying.huang@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ACPI: apei: Cast u64 to unsigned long, fix compile
 warning

On Sun, 12 Sep 2010 09:48:25 -0400
Javier Martinez Canillas <martinez.javier@...il.com> wrote:

> In today linux-net I got a compile warning in acpi/apei
> 
> drivers/acpi/apei/erst.c: In function ___erst_exec_move_data___:
> drivers/acpi/apei/erst.c:273: warning: cast to pointer from integer of different size
> drivers/acpi/apei/erst.c:274: warning: cast to pointer from integer of different size
> 
> The problem is that apei_exec_context->dst_base type is u64.
> But in 32 bits architecture void * is 32 bits long. 
> Casting it to unsigned long solves the issue
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>
> ---
>  drivers/acpi/apei/erst.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
> index a4904f1..37d7a05 100644
> --- a/drivers/acpi/apei/erst.c
> +++ b/drivers/acpi/apei/erst.c
> @@ -270,8 +270,8 @@ static int erst_exec_move_data(struct apei_exec_context *ctx,
>  	rc = __apei_exec_read_register(entry, &offset);
>  	if (rc)
>  		return rc;
> -	memmove((void *)ctx->dst_base + offset,
> -		(void *)ctx->src_base + offset,
> +	memmove((void *)(unsigned long)ctx->dst_base + offset,
> +		(void *)(unsigned long)ctx->src_base + offset,
>  		ctx->var2);
>  
>  	return 0;

This might indicate that the incorrect types were used within the
`struct apei_exec_context'.  I can't tell (or can't be bothered working
it out), because whoever wrote that didn't bother documenting any of it
at all.

Are those things kernel virtual addresses?  If so, a pointer type
should have been used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/