linux-kernel - Re: [PATCH 1/1] hid: prevent ILITEK multi-touch devices from being handled by usbhid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1009141109280.26813@pobox.suse.cz>
Date:	Tue, 14 Sep 2010 11:10:55 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Bradley Chen <bradley7213@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] hid: prevent ILITEK multi-touch devices from being
 handled by usbhid

On Sat, 11 Sep 2010, Bradley Chen wrote:

> From: Bradley Chen <bradley_chen@...tek.com>
> 
> The ILITEK multi-touch devices are incorrectly handled by the generic 
> USB driver(usbhid). This patch puts the IDs of ILITEK and its 
> multi-touch devices into hid_blacklist in order to have the products be 
> handled by specific drivers.
> 
> Signed-off-by: Bradley Chen <bradley_chen@...tek.com>
> ---
> diff -uprN -X linux-2.6.35.4-vanilla/Documentation/dontdiff linux-2.6.35.4-vanilla/drivers/hid/hid-core.c linux-2.6.35.4/drivers/hid
> /hid-core.c
> --- linux-2.6.35.4-vanilla/drivers/hid/hid-core.c	2010-09-11 16:12:25.295859677 +0800
> +++ linux-2.6.35.4/drivers/hid/hid-core.c	2010-08-27 07:47:12.000000000 +0800
> @@ -1302,7 +1302,6 @@ static const struct hid_device_id hid_bl
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_3) },
> -	{ HID_USB_DEVICE(USB_VENDOR_ID_ILITEK, USB_DEVICE_ID_ILITEK_MT2101) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_KENSINGTON, USB_DEVICE_ID_KS_SLIMBLADE) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_ERGO_525V) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) },
> diff -uprN -X linux-2.6.35.4-vanilla/Documentation/dontdiff linux-2.6.35.4-vanilla/drivers/hid/hid-ids.h linux-2.6.35.4/drivers/hid/
> hid-ids.h
> --- linux-2.6.35.4-vanilla/drivers/hid/hid-ids.h	2010-09-11 16:10:37.704360067 +0800
> +++ linux-2.6.35.4/drivers/hid/hid-ids.h	2010-08-27 07:47:12.000000000 +0800
> @@ -290,9 +290,6 @@
>  #define USB_DEVICE_ID_UGCI_FLYING	0x0020
>  #define USB_DEVICE_ID_UGCI_FIGHTING	0x0030
>  
> -#define USB_VENDOR_ID_ILITEK		0x222a
> -#define USB_DEVICE_ID_ILITEK_MT2101 	0x0001
> -
>  #define USB_VENDOR_ID_IMATION		0x0718
>  #define USB_DEVICE_ID_DISC_STAKKA	0xd000

Hi Bradley,

first, it seems that the patch is actually doing quite the reverse of what 
you wanted to do, right? (it's removing lines that have never been in 
kernel).

Second, what are the specific drivers? Are they going to be posted for 
upstream kernel inclusion?
How does the device behave with USB HID driver? It doesn't work at all, or 
it's just that it only providing basic HID capabilities without any 
vendor-specific extensions?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/