linux-kernel - Re: [34-stable regression] USB delay init quirk causes device events loss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201009141403.00600.oneukum@suse.de>
Date:	Tue, 14 Sep 2010 14:03:00 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Jiri Slaby <jslaby@...e.cz>, phil@...m.com, stable@...nel.org,
	Greg KH <gregkh@...e.de>, USB list <linux-usb@...r.kernel.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [34-stable regression] USB delay init quirk causes device events loss

Am Montag, 13. September 2010, 17:37:49 schrieb Alan Stern:
> Okay, I see the problem.  By moving usb_detect_quirks earlier, we end 
> up calling usb_disable_autosuspend too soon -- before the 
> pm_runtime_enable call in usb_new_device.  In 2.6.35 this doesn't 
> matter because the implementation of usb_autosuspend_device has 
> changed.
> 
> So yes, in the end it looks like the best course is to revert this
> patch from 2.6.34.stable.  This is unfortunate but I don't see any way
> around it without making changes that aren't present in the current
> kernel. For example, the pm_runtime_set_active and pm_runtime_enable
> calls could also be moved from usb_new_device into
> hub_port_connect_change.

Calling usb_detect_quirks() twice?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/