linux-kernel - Re: [PATCH] SCSI: fix qla4xxx build on PPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C8F672E.6050504@suse.cz>
Date:	Tue, 14 Sep 2010 14:14:38 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	James.Bottomley@...e.de, iscsi-driver@...gic.com,
	linux-scsi@...r.kernel.org, jirislaby@...il.com,
	linux-kernel@...r.kernel.org, Ravi Anand <ravi.anand@...gic.com>,
	Vikas Chaudhary <vikas.chaudhary@...gic.com>
Subject: Re: [PATCH] SCSI: fix qla4xxx build on PPC

On 09/14/2010 02:12 PM, Jiri Slaby wrote:
> We use read/write[bslq] but do not include linux/io.h. This causes
> build failures on PPC. Include that file.

Just in case you want to include the failure:
drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_8xxx_pci_mem_read_direct':
drivers/scsi/qla4xxx/ql4_nx.c:716:3: error: implicit declaration of
function 'readq'
drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_8xxx_pci_mem_write_direct':
drivers/scsi/qla4xxx/ql4_nx.c:787:3: error: implicit declaration of
function 'writeq'

> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Ravi Anand <ravi.anand@...gic.com>
> Cc: Vikas Chaudhary <vikas.chaudhary@...gic.com>
> ---
>  drivers/scsi/qla4xxx/ql4_nx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
> index 5d4a382..449256f 100644
> --- a/drivers/scsi/qla4xxx/ql4_nx.c
> +++ b/drivers/scsi/qla4xxx/ql4_nx.c
> @@ -5,6 +5,7 @@
>   * See LICENSE.qla4xxx for copyright and licensing details.
>   */
>  #include <linux/delay.h>
> +#include <linux/io.h>
>  #include <linux/pci.h>
>  #include "ql4_def.h"
>  #include "ql4_glbl.h"

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/