linux-kernel - Re: [PATCH] nouveau build regression, undefined reference to `acpi_video_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C8F7FDF.6090904@turmel.org>
Date:	Tue, 14 Sep 2010 09:59:59 -0400
From:	Phil Turmel <philip@...mel.org>
To:	Francisco Jerez <currojerez@...eup.net>
CC:	linux-kernel@...r.kernel.org, Ben Skeggs <bskeggs@...hat.com>,
	Matthew Garrett <mjg@...hat.com>,
	David Airlie <airlied@...ux.ie>,
	Marcin Kos'cielnicki <koriakin@...4.net>,
	Dave Airlie <airlied@...hat.com>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] nouveau build regression, undefined reference to `acpi_video_get_edid'

Francisco Jerez wrote:
> Phil Turmel <philip@...mel.org> writes:

[snip /]

>> Having the nouveau ACPI features depend on CONFIG_ACPI_VIDEO instead of
>> bare CONFIG_ACPI builds, boots, and works for me.

> nouveau_acpi_edid() is the only function that depends on ACPI_VIDEO,
> ifdef'ing out the rest of the ACPI stuff in that case doesn't make much
> sense to me.

Understood.  I noticed that DRM_I915 does a "select ACPI_VIDEO if ACPI",
which is why I mentioned that alternative below.  I don't recall how I got
the y+m combination above (I tend to build stuff in), but a randconfig
could certainly hit this.  I intend to leave it y+y when I'm done.

>> Presumably, this could also be solved by adding
>> "select ACPI_VIDEO if ACPI" to the nouveau Kconfig.
>> I'd be happy to try that, if this approach is flawed.

I'll test the Kconfig approach later today.

Regards,

Phil Turmel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/