[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100914205246.0e35c9af@lxorguk.ukuu.org.uk>
Date: Tue, 14 Sep 2010 20:52:46 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Timur Tabi <timur@...escale.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linuxppc-dev@...abs.org,
linux-kernel@...r.kernel.org, benh@...nel.crashing.org,
kumar.gala@...escale.com, amit.shah@...hat.com
Subject: Re: [PATCH] hvc_console: fix dropping of characters when output
byte channel is full
On Tue, 14 Sep 2010 14:25:34 -0500
Timur Tabi <timur@...escale.com> wrote:
> Alan Cox wrote:
> > Its a printk handler - better to lose the bytes than hang the box. I
> > think the current code is probably right.
>
> What do you think about this change:
>
> http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-October/thread.html#76830
>
> This is the original version of my patch. In it, I simply allow drivers to
> return 0 to indicate that they're too busy to accept data. It works great
> on the hvc driver that we have in-house today, but it might break other
> drivers that return 0 to indicate error.
If you want to make that change then I guess you need to audit every
other hvc driver first.
But I never understood the point of the hvc layer anyway 8)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists