linux-kernel - Re: [lm-sensors] [PATCH] x86/hwmon: fix initialization of coretemp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <4C8F35F10200007800015E5E@vpn.id2.novell.com>
Date:	Tue, 14 Sep 2010 07:44:33 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Chen Gong" <gong.chen@...ux.intel.com>
Cc:	<mingo@...e.hu>, <fenghua.yu@...el.com>, <tglx@...utronix.de>,
	<khali@...ux-fr.org>, <lm-sensors@...sensors.org>,
	<linux-kernel@...r.kernel.org>, <hpa@...or.com>
Subject: Re: [lm-sensors] [PATCH] x86/hwmon: fix initialization of
	 coretemp

>>> On 14.09.10 at 08:34, Chen Gong <gong.chen@...ux.intel.com> wrote:
> 于 9/13/2010 6:17 PM, Jan Beulich 写道:
>> Using cpuid_eax() to determine feature availability on other than
>> the current CPU is invalid. And feature availability should also be
>> checked in the hotplug code path.
>>
>> Signed-off-by: Jan Beulich<jbeulich@...ell.com>
>> Cc: Rudolf Marek<r.marek@...embler.cz>
>>
>> ---
>>   arch/x86/include/asm/cpufeature.h |    1 +
>>   arch/x86/kernel/cpu/scattered.c   |    1 +
>>   drivers/hwmon/coretemp.c          |   29 +++++++++++++----------------
>>   3 files changed, 15 insertions(+), 16 deletions(-)
>>
>> --- linux-2.6.36-rc4/arch/x86/include/asm/cpufeature.h	2010-09-13 
> 08:44:55.000000000 +0200
>> +++ 
> 2.6.36-rc4-x86-coretemp-feature-check/arch/x86/include/asm/cpufeature.h	20
> 10-09-01 09:18:17.000000000 +0200
>> @@ -168,6 +168,7 @@
>>   #define X86_FEATURE_XSAVEOPT	(7*32+ 4) /* Optimized Xsave */
>>   #define X86_FEATURE_PLN		(7*32+ 5) /* Intel Power Limit Notification */
>>   #define X86_FEATURE_PTS		(7*32+ 6) /* Intel Package Thermal Status */
>> +#define X86_FEATURE_DTS		(7*32+ 7) /* Digital Thermal Sensor */
> 
> Do we really need a new CPU flag ?

We don't strictly need one, but for one it parallels X86_FEATURE_PTS,
and it allows easy identification of the feature's availability from user
space.

Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/