linux-kernel - Re: [PATCH v3] mfd: tps6586x: add basic interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100915113244.GA17201@sortiz-mobl>
Date:	Wed, 15 Sep 2010 13:32:45 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Gary King <gking@...dia.com>
Cc:	linux-kernel@...r.kernel.org, mike@...pulab.co.il
Subject: Re: [PATCH v3] mfd: tps6586x: add basic interrupt support

On Wed, Sep 15, 2010 at 12:55:34PM +0200, Samuel Ortiz wrote:
> Hi Gary,
> 
> On Mon, Sep 13, 2010 at 06:37:42PM -0700, Gary King wrote:
> > Hi Samuel, Mike,
> > 
> > This patch incorporates Mike's feedback to my v2 patch to add interrupt
> > support to the tps6586x driver.
> > 
> > Changes since v2:
> >  * Remove stale comment in commit message
> > 
> > Changes since v1:
> >  * Move the interrupt enum ordering to match the ACK register values
> > 
> >  * Treat the INT_ACK registers as a single 32b unsigned int.
> > 
> >  * Name and define all the interrupts on the device
> > 
> >  * If reading the ACK registers in the interrupt thread fails, IRQ_NONE
> >    is returned, rather than disabling the IRQ handler. This fixes
> >    interrupts following suspend.
> > 
> >  * The cascaded IRQ is passed through the i2c_client's .irq field, rather
> >    than through platform data.
> Patch applied, many thanks.
...with this build fix:


diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 01c928b..385cc38 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -563,8 +563,8 @@ config MFD_JZ4740_ADC
 	  This driver is necessary for jz4740-battery and jz4740-hwmon driver.
 
 config MFD_TPS6586X
-	tristate "TPS6586x Power Management chips"
-	depends on I2C && GPIOLIB
+	bool "TPS6586x Power Management chips"
+	depends on I2C && GPIOLIB && GENERIC_HARDIRQS
 	select MFD_CORE
 	help
 	  If you say yes here you get support for the TPS6586X series of

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/