linux-kernel - Re: [tip:perf/core] hw breakpoints: Fix pid namespace bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100915114556.GA18760@elte.hu>
Date:	Wed, 15 Sep 2010 13:45:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, acme@...hat.com,
	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	will.deacon@....com, matthltc@...ibm.com,
	mahesh@...ux.vnet.ibm.com, rostedt@...dmis.org, tglx@...utronix.de,
	prasad@...ux.vnet.ibm.com, greenrd@...enrd.org,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] hw breakpoints: Fix pid namespace bug


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> On Wed, Sep 15, 2010 at 10:03:06AM +0000, tip-bot for Matt Helsley wrote:
> > Commit-ID:  d958077d007d98125766d11e82da2fd6497b91d6
> > Gitweb:     http://git.kernel.org/tip/d958077d007d98125766d11e82da2fd6497b91d6
> > Author:     Matt Helsley <matthltc@...ibm.com>
> > AuthorDate: Mon, 13 Sep 2010 13:01:18 -0700
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Wed, 15 Sep 2010 10:43:59 +0200
> > 
> > hw breakpoints: Fix pid namespace bug
> > 
> > Hardware breakpoints can't be registered within pid namespaces
> > because tsk->pid is passed rather than the pid in the current
> > namespace.
> > 
> > (See https://bugzilla.kernel.org/show_bug.cgi?id=17281 )
> > 
> > This is a quick fix demonstrating the problem but is not the
> > best method of solving the problem since passing pids internally
> > is not the best way to avoid pid namespace bugs. Subsequent patches
> > will show a better solution.
> > 
> > Much thanks to Frederic Weisbecker <fweisbec@...il.com> for doing the
> > bulk of the work finding this bug.
> > 
> > Signed-off-by: Matt Helsley <matthltc@...ibm.com>
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Cc: Robin Green <greenrd@...enrd.org>
> > Cc: Prasad <prasad@...ux.vnet.ibm.com>
> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Will Deacon <will.deacon@....com>
> > Cc: Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>
> > LKML-Reference: <f63454af09fb1915717251570423eb9ddd338340.1284407762.git.matthltc@...ibm.com>
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > ---
> 
> 
> Aiie, you have been too fast too apply that on -tip, [...]

Came from Peter.

> [...] especially it should go to perf/urgent with some stable backport 
> tags. And I need to test them as he said that was only compile tested.

No problem, mind cherry-picking it into an urgent pull request? The 
overlap is not an issue.

> Lemme just check it really fixes the issue and I'll package his three 
> patches in according pull requests.

Ok!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/