linux-kernel - Re: [PATCH V3] [X86] Fix potential issue on memmove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C9119B1.7020808@zytor.com>
Date:	Wed, 15 Sep 2010 12:08:33 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	ling.ma@...el.com
CC:	mingo@...e.hu, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] [X86] Fix potential issue on memmove

On 09/14/2010 06:50 PM, ling.ma@...el.com wrote:
> From: Ma Ling <ling.ma@...el.com>
> 
> memmove allow source and destination address to be overlap, 
> but no limitation for memcpy. So memmove use forward or
> backward copy mode to handle src > dest and dest > src cases respectively.
> However memcpy has not address overlap, it may use any copy mode
> theoretically. Our original memmove will call memcpy and assume
> it must use forward copy mode, otherwise the system will crash,
> it is potential issue. The patch based on tip/x86/mem avoids
> this assumption.
> 
> Signed-off-by: Ma Ling <ling.ma@...el.com>

This patch is certainly not based on the current tip:x86/mem.  Could you
check out the current tip:x86/mem (which has a previous patch of yours
in it) and submit an incremental patch with a description about what
updates the previous patch and why?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/