linux-kernel - Re: [RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating PM workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C91D132.6090607@kernel.org>
Date:	Thu, 16 Sep 2010 10:11:30 +0200
From:	Tejun Heo <tj@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
CC:	Linux-pm mailing list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating
 PM workqueue

Hello, Rafael.

On 09/15/2010 09:56 PM, Rafael J. Wysocki wrote:
> I'm not sure about that WQ_RESCUER thing.  Can you please tell me what
> exactly it is for?

It's to guarantee forward progress for workqueues which process work
items which may be used to reclaim memory.  It reserves a rescue
worker thread to be used under memory pressure.  I finished workqueue
documentation a few days ago and sent pull request to Linus.

  http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f

So, for pm_wq, there's no reason to use WQ_RESUER.
alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Thanks for doing it.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/