linux-kernel - Re: [PATCH] drivers/usb/serial/mos*: prevent reading uninitialized stack memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100916093922.197ebe18@lxorguk.ukuu.org.uk>
Date:	Thu, 16 Sep 2010 09:39:22 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dan Rosenberg <drosenberg@...curity.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	security@...nel.org, stable@...nel.org
Subject: Re: [PATCH] drivers/usb/serial/mos*: prevent reading uninitialized
 stack memory

On Wed, 15 Sep 2010 17:44:16 -0400
Dan Rosenberg <drosenberg@...curity.com> wrote:

> The TIOCGICOUNT device ioctl in both mos7720.c and mos7840.c allows
> unprivileged users to read uninitialized stack memory, because the
> "reserved" member of the serial_icounter_struct struct declared on the
> stack is not altered or zeroed before being copied back to the user.
> This patch takes care of it.

ACK ... but this is the wrong way to fix these. We'll be squashing new
ones between here and eternity if we just stick memsets in. It wants
making a tty operation off the tty ioctl code so that there is one place
that clears it and copies it to the user.

I'll have a look at what is needed - I don't think very much.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/