linux-kernel - Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C91DF20.7040807@grandegger.com>
Date:	Thu, 16 Sep 2010 11:10:56 +0200
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Masayuki Ohtake <masa-korg@....okisemi.com>
CC:	Marc Kleine-Budde <mkl@...gutronix.de>, arjan@...ux.intel.com,
	Tomoya MORINAGA <morinaga526@....okisemi.com>,
	yong.y.wang@...el.com, gregkh@...e.de, qi.wang@...el.com,
	andrew.chih.howe.khor@...el.com, meego-dev@...go.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	socketcan-core@...ts.berlios.de,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Barry Song <21cnbao@...il.com>,
	Christian Pellegrin <chripell@...e.org>,
	Wolfram Sang <w.sang@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_CAN driver to 2.6.35

On 09/16/2010 10:51 AM, Masayuki Ohtake wrote:
> Hi Marc,
> 
>> - Please remove rx-filter handling from the driver completely, simply
>>   receive every can frame
> 
> This rx-filter function is for Topcliff's CAN HW function.
> This function is important.
> Could you tell us the reason why should we remove filter function ?

We do not (yet) support the filtering capability of the CAN controller
hardware. Therefore please configure the hardware filter to accept *any*
CAN message like all other drivers do, e.g.:

http://lxr.linux.no/#linux+v2.6.35.4/drivers/net/can/sja1000/sja1000.c#L249

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/