linux-kernel - Re: agp/intel: Fix the pre-9xx chipset flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4C922C700200007800016CB4@vpn.id2.novell.com>
Date:	Thu, 16 Sep 2010 13:40:48 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<eric@...olt.net>
Cc:	<Brice.Goglin@...-lyon.org>, <airlied@...ux.ie>,
	<linux-kernel@...r.kernel.org>
Subject: Re: agp/intel: Fix the pre-9xx chipset flush

Eric,

in this patch you removed from intel_i830_setup_flush() a call to
map_page_into_agp(), but you left in place the counterpart call from
intel_i830_fini_flush() to unmap_page_from_agp()? Isn't it mere luck
that on x86 this is only a call to set_pages_wb()?

Further, is there really a point in doing the respective allocation
with GFP_DMA32? Nor does __GFP_ZERO seem really necessary...

Thanks, Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/