linux-kernel - Re: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100916180710.07821bdd@lxorguk.ukuu.org.uk>
Date:	Thu, 16 Sep 2010 18:07:10 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Dan Rosenberg <drosenberg@...curity.com>, j.dumon@...ion.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	security@...nel.org, davem@...emloft.net, stable@...nel.org
Subject: Re: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized
 memory

->tiocmget;
> >  
> > +	memset(&icount, 0, sizeof(struct serial_icounter_struct));
> > +
> 
> Move the above to after the spinlocks.

Why - its a local variable ?

Easier to write

	struct serial_icounter_struct icount = { 0 };

though
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/