linux-kernel - Re: [RFC][PATCH] Cross Memory Attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1284657194.2275.585.camel@laptop>
Date:	Thu, 16 Sep 2010 19:13:14 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Christopher Yeoh <cyeoh@....ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] Cross Memory Attach

On Thu, 2010-09-16 at 09:54 -0700, Linus Torvalds wrote:
> On Thu, Sep 16, 2010 at 9:27 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> > On Wed, 2010-09-15 at 08:11 -0700, Linus Torvalds wrote:
> >
> >>    if (copy_to)
> >>       ret = copy_from_user(..);
> >>    else
> >>       ret = copy_to_user(..);
> >>    kunmap(process_pages[i]);
> >>    if (ret)
> >>       goto out;
> >
> > Shouldn't we be using kmap_atomic()
> 
> Over a copy_to/from_user? Not bloody likely.

Gah, indeed. OK, since its not nested kmap() should indeed work. The
alternative is using get_user_pages() on both address spaces, but I
guess that makes things unnecessarily complex.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/