linux-kernel - Re: amba_pl022 spi->mode fix/cleanup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100916031436.GA7542@angua.secretlab.ca>
Date:	Wed, 15 Sep 2010 21:14:36 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	wellsk40@...il.com
Cc:	linus.walleij@...ricsson.com,
	spi-devel-general@...ts.sourceforge.net, sameo@...ux.intel.com,
	rabin.vincent@...ricsson.com, srinidhi.kasagar@...ricsson.com,
	linux-kernel@...r.kernel.org, linux@....linux.org.uk,
	u.kleine-koenig@...gutronix.de,
	linux-arm-kernel@...ts.infradead.org, tj@...nel.org,
	Lukasz.Baj@...to.com, quentinyang05@...il.com
Subject: Re: amba_pl022 spi->mode fix/cleanup patches

On Fri, Sep 10, 2010 at 09:19:34AM -0700, wellsk40@...il.com wrote:
> This patch series updates drivers and platforms that depend on the
> amba_pl022 driver and use the pl022_config_chip structure for
> setting up the SPI mode and data transfer width.
> 
> The SPI configuration (CPOL/CPHA mode, bit send order, data bits per
> word, and loopback mode) were previously setup as part of board
> specific data in the pl022_config_chip structure. This has been
> changed to now use the .mode field in spi_board_info structure (or
> drivers that setup the mode). The SPI transfer's data width is now
> configured from spi->bits_per_word.
> 
> The SPI driver changes have been previously submitted to the SPI ML.
> This patch series need to be layered on that patch series.
> 
> These changes add or fix the .mode field in the plats/boards that use the
> driver (u300, ux500, lpc32xx). The patches also move the data width
> from the board specific area to the driver for mfd/ab8500. As the
> fields in the pl022_config_chip structure are no longer needed, they
> are removed in the last patch.
> 
> These changes have been tested on the phy3250 platform (lpc32xx). I
> was able to test the ab8500 driver to some degree, but I only have a
> standard pl022. I am unable to test u300 and ux500 changes, but the
> u300 changes compiled fine.
> 
> [PATCH 1/5] mfd/ab8500: Setup SPI transfer for 24 bits
> [PATCH 2/5] ARM: LPC32XX: Add missing SPI mode and remove unused fields
> [PATCH 3/5] ARM: U300: spi->mode and spi_bits_per_words updates
> [PATCH 4/5] ARM: Ux500: Change SPI mode and remove unused fields
> [PATCH 5/5] spi: amba_pl022: Remove unused fields from pl022_config_chip

There are ordering issues with these patches and the patch they depend
on.  Basically, as-is it is not bisectable.  The above platforms stop
working after the SPI driver changes are applied, but before these
patches are.  You'll need to update the mode field for all the users
in or before the SPI driver changes patch to preserve bisectability.
Then you can have subsequent cleanup patches....

Or just squash all the patches into the SPI driver patch.  I'd be
okay with that in this case because the board changes are well
contained and easy to understand.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/