linux-kernel - Re: [PATCH] block: remove BLKDEV_IFL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C92680D.1030605@fusionio.com>
Date:	Thu, 16 Sep 2010 20:55:09 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Christoph Hellwig <hch@....de>
CC:	"tj@...nel.org" <tj@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: remove BLKDEV_IFL_WAIT

On 2010-09-16 18:14, Christoph Hellwig wrote:
> All the blkdev_issue_* helpers can only sanely be used for synchronous
> caller.  To issue cache flushes or barriers asynchronously the caller needs
> to set up a bio by itself with a completion callback to move the asynchronous
> state machine ahead.  So drop the BLKDEV_IFL_WAIT flag that is always
> specified when calling blkdev_issue_* and also remove the now unused flags
> argument to blkdev_issue_flush and blkdev_issue_zeroout.  For
> blkdev_issue_discard we need to keep it for the secure discard flag, which
> gains a more descriptive name and loses the bitops vs flag confusion.

Thanks, applied. I think we still have a missing unplug for these cases,
I'll take a look at that.

-- 
Jens Axboe


Confidentiality Notice: This e-mail message, its contents and any attachments to it are confidential to the intended recipient, and may contain information that is privileged and/or exempt from disclosure under applicable law. If you are not the intended recipient, please immediately notify the sender and destroy the original e-mail message and any attachments (and any copies that may have been made) from your system or otherwise. Any unauthorized use, copying, disclosure or distribution of this information is strictly prohibited.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/