linux-kernel - Re: [PATCH -next] staging/keucr: update TODO list and ask question about it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100916192831.GB10397@kroah.com>
Date:	Thu, 16 Sep 2010 12:28:31 -0700
From:	Greg KH <greg@...ah.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>, gregkh@...e.de,
	Al Cho <acho@...ell.com>,
	driverdevel <devel@...verdev.osuosl.org>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] staging/keucr: update TODO list and ask question
 about it

On Tue, Sep 14, 2010 at 03:41:48PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Update keucr TODO with additional work items.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Al Cho <acho@...ell.com>
> ---
>  drivers/staging/keucr/TODO |    3 +++
>  1 file changed, 3 insertions(+)
> 
> and I don't understand this TODO comment:
> "	- determine if the driver should not be using a duplicate
> 	  version of the usb-storage scsi interface code, but should
> 	  be merged into the drivers/usb/storage/ directory and
> 	  infrastructure instead."
> 
> Of course the driver should not use a duplicate of the usb-storage
> SCSI interface code.  Did someone seriously think that it should?

Well, it's not the whole copy, and we are still trying to unwind the
hooks here.  It might be that this is just another scsi driver, one that
happens to also be a USB device, as I don't think this device follows
the usb-storage spec at all.

So it's still an unanswered question.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/