linux-kernel - [PATCH] lio-target: Enable crc32c_x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1284668579-10260-1-git-send-email-nab@linux-iscsi.org>
Date:	Thu, 16 Sep 2010 13:22:59 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Mike Christie <michaelc@...wisc.edu>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Hannes Reinecke <hare@...e.de>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	Konrad Rzeszutek Wilk <konrad@...nok.org>,
	Douglas Gilbert <dgilbert@...erlog.com>,
	Joe Eykholt <jeykholt@...co.com>,
	Boaz Harrosh <bharrosh@...asas.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>
Subject: [PATCH] lio-target: Enable crc32c_x86_offload=1 by default

From: Nicholas Bellinger <nab@...ux-iscsi.org>

Greetings all,

This patch enables the default usage of the SSE v4.2 CRC32C instruction
for iSCSI target HeaderDigests and DataDigests offload using libcrypto and
the crc32c-intel.ko module on Nehalem systems.  This was originally disabled
by default in commit 047eeb75ee8f0 due to some issues with HeaderDigests=CRC32C
that where encountered with the Open-iSCSI initiator shipping with RHEL 6 B1.
This has now been identified as initiator side breakage, so we go ahead and
enable crc32c_x86_offload=1 by default when available.

Many thanks again to Mike Christie for verifying the Open-iSCSI side issue!

Signed-off-by: Nicholas A. Bellinger <nab@...ux-iscsi.org>
---
 drivers/target/lio-target/iscsi_target_core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/target/lio-target/iscsi_target_core.h b/drivers/target/lio-target/iscsi_target_core.h
index de962c8..882bd52 100644
--- a/drivers/target/lio-target/iscsi_target_core.h
+++ b/drivers/target/lio-target/iscsi_target_core.h
@@ -84,7 +84,7 @@
 /* Disabled by default in production mode w/ explict ACLs */
 #define TA_PROD_MODE_WRITE_PROTECT	0
 /* Disabled by default for the moment for testing... */
-#define TA_CRC32C_X86_OFFLOAD		0
+#define TA_CRC32C_X86_OFFLOAD		1
 #define TA_CACHE_CORE_NPS		0
 
 /* struct iscsi_data_count->type */
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/