linux-kernel - Re: [PATCH 12/12] BKL: Remove BKL from OCFS2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100916222637.GB32307@wotan.suse.de>
Date:	Thu, 16 Sep 2010 15:26:37 -0700
From:	Mark Fasheh <mfasheh@...e.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-kernel@...r.kernel.org, Joel Becker <joel.becker@...cle.com>
Subject: Re: [PATCH 12/12] BKL: Remove BKL from OCFS2

On Thu, Sep 16, 2010 at 07:46:25PM +0200, Arnd Bergmann wrote:
> The BKL in ocfs2/dlmfs is used in put_super, fill_super and remount_fs
> that are all three protected by the superblocks s_umount rw_semaphore.

Those look good, thanks.


> The use in ocfs2_control_open is evidently unrelated and the function
> is protected by ocfs2_control_lock.

<snip>

> @@ -612,12 +611,10 @@ static int ocfs2_control_open(struct inode *inode, struct file *file)
>  		return -ENOMEM;
>  	p->op_this_node = -1;
>  
> -	lock_kernel();
>  	mutex_lock(&ocfs2_control_lock);
>  	file->private_data = p;
>  	list_add(&p->op_list, &ocfs2_control_private_list);
>  	mutex_unlock(&ocfs2_control_lock);
> -	unlock_kernel();
>  
>  	return 0;
>  }

My guess is that this one is good to go too. Joel?
	--Mark

--
Mark Fasheh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/