[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100916062232.GC3393@legolas.emea.dhcp.ti.com>
Date: Thu, 16 Sep 2010 09:22:32 +0300
From: Felipe Balbi <balbi@...com>
To: "Gadiyar, Anand" <gadiyar@...com>
Cc: "Balbi, Felipe" <balbi@...com>,
Sergei Shtylyov <sshtylyov@...sta.com>,
Ming Lei <tom.leiming@...il.com>,
"greg@...ah.com" <greg@...ah.com>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
David Brownell <dbrownell@...rs.sourceforge.net>,
Mike Frysinger <vapier@...too.org>
Subject: Re: [Discussion] USB: musb-gadget: how to fix ZLP issue in
musb_g_tx
On Thu, Sep 16, 2010 at 01:15:32AM -0500, Gadiyar, Anand wrote:
>On Thu, Sep 16, 2010 at 11:35 AM, Felipe Balbi <balbi@...com> wrote:
>> Hi,
>>
>> On Wed, Sep 15, 2010 at 08:10:15AM -0500, Sergei Shtylyov wrote:
>>>
>>> I don't see what to rework. The last short packet should still satisfy
>>> (request->actual == request->length) condition, no?
>>
>> of course not, it's short not zero. so the last short packet can be
>> anything from 1 to 511 bytes.
>>
>
>If it's TX, both condtions should automatically be true, right?
even in mode1 ? I have to revist my docs, but afaict mode1 won't
transmit last short packet, no matter if it's tx or rx. Could be wrong,
though.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists