linux-kernel - Re: platform: Re: #2 (Re: More modaliases + patchtool))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100917135410.GB29739@sirena.org.uk>
Date:	Fri, 17 Sep 2010 14:54:15 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	mahatma@...by
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>, lrg@...mlogic.co.uk,
	kuninori.morimoto.gx@...esas.com
Subject: Re: platform: Re: #2 (Re: More modaliases + patchtool))

On Fri, Sep 17, 2010 at 04:42:05PM +0300, Dzianis Kahanovich wrote:
> ...
> Last (14 buses)

Please do try to follow the recommendations in SubmittingPatches,
including those regarding the formatting of your mails and CCing
relevant maintainers and lists.

> Fix lost PLATFORM modalias
> 
> Signed-off-by: Dzianis Kahanovich <mahatma@...by>
> 
> --- linux-2.6.36-rc4-git3/sound/soc/sh/fsi.c	2010-09-17 12:30:32.000000000 +0300
> +++ b/sound/soc/sh/fsi.c	2010-09-17 12:39:08.026437283 +0300
> @@ -1250,6 +1250,9 @@ static void __exit fsi_mobile_exit(void)
>  {
>  	platform_driver_unregister(&fsi_driver);
>  }
> +
> +MODULE_DEVICE_TABLE(platform, fsi_id_table);
> +

The normal style for this stuff would be to put the MODULE_DEVICE_TABLE()
next to the actual table.  I will apply a version of your patch with the
addition moved.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/