linux-kernel - Re: [PATCH 0/8] Drop host_lock around LLD SHT->queuecommand() caller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1284750112.7280.160.camel@schen9-DESK>
Date:	Fri, 17 Sep 2010 12:01:52 -0700
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Vasu Dev <vasu.dev@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	James Bottomley <James.Bottomley@...e.de>,
	Mike Christie <michaelc@...wisc.edu>,
	James Smart <james.smart@...lex.com>,
	Andrew Vasquez <andrew.vasquez@...gic.com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Hannes Reinecke <hare@...e.de>,
	Joe Eykholt <jeykholt@...co.com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 0/8] Drop host_lock around LLD SHT->queuecommand()
 caller

On Fri, 2010-09-17 at 14:26 -0400, Jeff Garzik wrote:

> 
> But that raises the familiar tale of:  using multiple atomics (w/ their 
> locked instructions) may cost more than a spinlock.
> 

As brought up by James earlier, the scsi_host lock was used in so many
places that getting rid of it here to reduce contention for it will be a
net win, even with the cost of the atomics.  And for most LLDs that
don't need the serial number, we can just initialize it to zero for
those and have no need to increment it (thus also avoiding the atomics'
cost).

Tim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/