linux-kernel - Re: linux-next: build warnings in Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Sep 2010 14:26:30 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Len Brown <lenb@...nel.org>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus <torvalds@...ux-foundation.org>
Subject: Re: linux-next: build warnings in Linus' tree

Hi Len,

On Mon, 30 Aug 2010 14:08:02 +0800 Zhang Rui <rui.zhang@...el.com> wrote:
>
> On Mon, 2010-08-30 at 09:42 +0800, Stephen Rothwell wrote:
> > Hi Len,
> > 
> > On Tue, 17 Aug 2010 11:24:39 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> > >
> > > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > > 
> > > drivers/acpi/sysfs.c:152: warning: passing argument 1 of '__check_old_set_param' from incompatible pointer type
> > > include/linux/moduleparam.h:165: note: expected 'int (*)(const char *, struct kernel_param *)' but argument is of type 'int (*)(const char *, const struct kernel_param *)'

[several more elided]

> > > Introduced by commit 1c8fce27e275fd7c6b75bc6455745f02d3903ee6 ("ACPI:
> > > introduce drivers/acpi/sysfs.c") interacting with commit
> > > 9bbb9e5a33109b2832e2e63dcc7a132924ab374b ("param: use ops in struct
> > > kernel_param, rather than get and set fns directly").
> > 
> > Can we have this fixed, please?
> patch attached. :)
> 
> Use module_param_cb instead of the obsoleted module_param_call to fix a build warning.
> 
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>

Now that this has been in linux-next since Sep 6, can you please send it
to Linus.  It removes quite a few warnings that were introduced during
this merge window - and I think we already have too many warnings.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped