linux-kernel - New compat_alloc_user_space() GPLness and fglrx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100918014232.GA17699@khazad-dum.debian.net>
Date:	Fri, 17 Sep 2010 22:42:32 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: New compat_alloc_user_space() GPLness and fglrx

commit c41d68a513c71e35a14f66d71782d27a79a81ea6
compat: Make compat_alloc_user_space() incorporate the access_ok()

promotes compat_alloc_user_space() to EXPORT_SYMBOL_GPL, and moves it from
asm/compat.h to linux/compat.h.

This breaks AMD/ATI's proprietary fglrx GPU driver, which wants to use
compat_alloc_user_space(), and expects to find it in asm/compat.h.

Fixing this on the fglrx side is easy enough, one can simply audit the two
or three call sites in the fglrx glue and make sure they can use
arch_compat_alloc_user_space() safely.

But such a fix doesn't look right.  IMHO, either we don't want any non-GPL
module touching *_compat_alloc_user_space and compat_alloc_user_space, or it
would be better to let them use compat_alloc_user_space() in the interest of
overall security...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/