linux-kernel - Re: [PATCH v4 1/2] init: add sys-wrapper.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100918025057.ae9c3ce3.akpm@linux-foundation.org>
Date:	Sat, 18 Sep 2010 02:50:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Namhyung Kim <namhyung@...il.com>, Sam Ravnborg <sam@...nborg.org>,
	Phillip Lougher <phillip@...gher.demon.co.uk>,
	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] init: add sys-wrapper.h

On Sat, 18 Sep 2010 11:27:46 +0200 Arnd Bergmann <arnd@...db.de> wrote:

> On Friday 17 September 2010, Andrew Morton wrote:
> > > -     int err = sys_mount(name, "/root", fs, flags, data);
> > > +     int err = kernel_sys_mount(name, "/root", fs, flags, data);
> > 
> > It would be good if we could arrange for all kernel syscalls to use
> > the wrappers.  ie: cause a direct call to sys_mount() to not compile?
> > 
> > I don't know how practical that would be.
> 
> One common reason to call a sys_* function is to implement another
> system call, e.g. sys_socketcall calling sys_socket or
> compat_sys_timer_create calling sys_timer_create.
> 
> I think in those cases we don't really want to go through another
> wrapper.

The overhead is zero in the case of sys_socket() and somewhat non-zero
in the case of sys_timer_create().  I can't immediately see a
convenient way of reducing "somewhat" to zero.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/