linux-kernel - Re: [PATCH] w35und: Add locking problems to TODO list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100919214039.GB12416@elf.ucw.cz>
Date:	Sun, 19 Sep 2010 23:40:39 +0200
From:	Pavel Machek <pavel@....cz>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	Lars Lindley <lindley@...ote.org>,
	Ruslan Pisarev <ruslan@...sarev.org.ua>
Subject: Re: [PATCH] w35und: Add locking problems to TODO list

Hi!

> The w35und uses atomics such as "ThreadCount" and "FireCount" to emulate
> locking in the TX paths, for example. Document this bug in the TODO list.
> 
> Cc: Lars Lindley <lindley@...ote.org>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Ruslan Pisarev <ruslan@...sarev.org.ua>
> Signed-off-by: Pekka Enberg <penberg@...nel.org>
> ---
>  drivers/staging/winbond/TODO |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/winbond/TODO b/drivers/staging/winbond/TODO
> index 43bee56..b4c592a 100644
> --- a/drivers/staging/winbond/TODO
> +++ b/drivers/staging/winbond/TODO
> @@ -6,6 +6,7 @@ TODO:
>  	- remove unused ioctls
>  	- use cfg80211 for regulatory stuff
>  	- fix 4k stack problems
> +	- fix locking problems (it's done using atomics...)

Being more verbose here would be good; list all the variables or at
least structures they are in, or something...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/